Discussion:
SF.net SVN: bluefish:[8393] trunk/bluefish/src
Olivier Sessink
2014-10-11 10:23:54 UTC
Permalink
hmmm a few years ago I changed all these symbols to the gtk3 equivalent
and included the old keycodes for backwards compatibility. I rather keep
the code compatible with the newest standards and a header for backwards
compatibility than the other way around.

what do you think?

Olivier
Revision: 8393
http://sourceforge.net/p/bluefish/code/8393
Author: jimh6583
Date: 2014-10-10 02:40:46 +0000 (Fri, 10 Oct 2014)
-----------
Use GTK2 key syms to remain compatible with GTK 2 versions prior to 2.24.x
--------------
trunk/bluefish/src/bftextview2.c
trunk/bluefish/src/bftextview2_autocomp.c
trunk/bluefish/src/bfwin.c
trunk/bluefish/src/gtk_easy.c
trunk/bluefish/src/plugin_infbrowser/infb_gui.c
trunk/bluefish/src/plugin_snippets/snippets_gui.c
--
Bluefish website http://bluefish.openoffice.nl/
Blog http://oli4444.wordpress.com/
Jim Hayward
2014-10-11 14:19:41 UTC
Permalink
Post by Olivier Sessink
hmmm a few years ago I changed all these symbols to the gtk3 equivalent
and included the old keycodes for backwards compatibility. I rather keep
the code compatible with the newest standards and a header for backwards
compatibility than the other way around.
what do you think?
I agree, but my preference is not to override defines in GTK. This is
the reason for using <gdk/gdkkeysyms-compat.h> for GTK3. This is the
method I used when originally porting a lot of Bluefish code to GTK3.

My long term preference would be to drop GTK2 support in svn trunk and
move GTK2 support to its own branch for bug fixes. Move svn trunk
towards a GTK3 and newer only Bluefish 3.0 release.

Regards,
Jim H

Loading...