html toolbar truncated message of Quickbar

[Andrius]

Hi all,
I am wondering if You are seeing the same as I do

In Quickbar of htmlbar toolbar, when there are no buttons added there should be message like this:"Right click any html toolbar button to add it to the Quickbar.” However, on my system (MacOSX) it shows “
”. On some other WinXP  system it shows “Ri
”. If I apply patch:
===================================================================
--- src/plugin_htmlbar/htmlbar_uimanager.c    (revision 8309)
+++ src/plugin_htmlbar/htmlbar_uimanager.c    (working copy)
@@ -1384,7 +1384,6 @@
         GtkWidget *label;
         GtkToolItem *ti = gtk_tool_item_new();
         label = gtk_label_new(_("Right click any html toolbar button to add it to the Quickbar."));
-        gtk_label_set_ellipsize(GTK_LABEL(label), PANGO_ELLIPSIZE_END);
         gtk_container_add(GTK_CONTAINER(ti), label);
         gtk_toolbar_insert(GTK_TOOLBAR(toolbar),ti,0);
     }

then the text shows OK.  Maybe we do not need gtk_label_set_ellipsize() if we want to show full text?
Any comments?
Andrius

[Jim Hayward]

This post might be inappropriate. Click to display it.

[Olivier Sessink]

Post by Andrius
Hi all,
I am wondering if You are seeing the same as I do

In Quickbar of htmlbar toolbar, when there are no buttons added there
should be message like this:"Right click any html toolbar button to
add it to the Quickbar.” However, on my system (MacOSX) it shows “
”.
===================================================================
--- src/plugin_htmlbar/htmlbar_uimanager.c (revision 8309)
+++ src/plugin_htmlbar/htmlbar_uimanager.c (working copy)
@@ -1384,7 +1384,6 @@
GtkWidget *label;
GtkToolItem *ti = gtk_tool_item_new();
label = gtk_label_new(_("Right click any html toolbar button
to add it to the Quickbar."));
- gtk_label_set_ellipsize(GTK_LABEL(label), PANGO_ELLIPSIZE_END);
gtk_container_add(GTK_CONTAINER(ti), label);
gtk_toolbar_insert(GTK_TOOLBAR(toolbar),ti,0);
}
then the text shows OK. Maybe we do not need
gtk_label_set_ellipsize() if we want to show full text?
Any comments?
Andrius

I think this line was added because this label was making the minimum
horizontal width of the bluefish window quite big.

it's weird that on OSX and XP the label is already shortened even if
there is space available. Could it be that this is only happening on gtk
2 ? So perhaps we need this only on gtk 3?

Olivier

[Andrius]

In think this happens on both gtk+2 and gtk+3 : on WinXP I tested stock 2.2.5 that uses gtk2, while on MacOSX I use gtk 3.6.4.
Andrius

________________________________
Sent: Sunday, April 6, 2014 11:00 AM
Subject: Re: html toolbar truncated message of Quickbar
Hi all,

Post by Andrius
I am wondering if You are seeing the same as I do

In Quickbar of htmlbar toolbar, when there are no buttons

added there should be message like this:"Right click any html
toolbar button to add it to the Quickbar.” However, on my
system (MacOSX) it shows “
”. On some other WinXP  system it

Post by Andrius
===================================================================
--- src/plugin_htmlbar/htmlbar_uimanager.c    (revision 8309)
+++ src/plugin_htmlbar/htmlbar_uimanager.c    (working copy)
@@ -1384,7 +1384,6 @@
         GtkWidget *label;
         GtkToolItem *ti = gtk_tool_item_new();
         label = gtk_label_new(_("Right click any html toolbar

button to add it to the Quickbar."));

Post by Andrius
-        gtk_label_set_ellipsize(GTK_LABEL(label), PANGO_ELLIPSIZE_END);
         gtk_container_add(GTK_CONTAINER(ti), label);
         gtk_toolbar_insert(GTK_TOOLBAR(toolbar),ti,0);
     }
then the text shows OK.  Maybe we do not need

gtk_label_set_ellipsize() if we want to show full text?

Post by Andrius
Any comments?
Andrius

I think this line was added because this label was making the

minimum horizontal width of the bluefish window quite big.

it's weird that on OSX and XP the label is already shortened even if

there is space available. Could it be that this is only happening on
gtk 2 ? So perhaps we need this only on gtk 3?

Olivier
--

Bluefish website http://bluefish.openoffice.nl/ Blog http://oli4444.wordpress.com/

[Andrius]

In think this happens on both gtk+2 and gtk+3 : on WinXP I tested stock 2.2.5 that uses gtk2, while on MacOSX I use gtk 3.6.4.
Andrius

P.S there seems to be some issues with mailing list, since emails are not relayed.

________________________________
it's weird that on OSX and XP the label is already shortened even if

there is space available. Could it be that this is only happening on
gtk 2 ? So perhaps we need this only on gtk 3?

Olivier
--

Bluefish website http://bluefish.openoffice.nl/ Blog http://oli4444.wordpress.com/

[Jim Hayward]

Post by Olivier Sessink
I think this line was added because this label was making the minimum
horizontal width of the bluefish window quite big.

Looking at my archive of commit messages, that actually goes back to
2004 :), you committed the change to fix a bug if the htmlbar was shown
in the side panel.

Log Message:
-----------
fixes the very wide label in the quickbar if it doesn't have items and
is shown in the sidepanel


Regards,
Jim H

[Andrius]

This works best for me:
if (htmlbar_v.in_sidepanel) {
            gtk_label_set_line_wrap(GTK_LABEL(label), TRUE);
        }
instead of
gtk_label_set_ellipsize(GTK_LABEL(label), PANGO_ELLIPSIZE_END);
Can You confirm?
Andrius

________________________________
Subject: Re: html toolbar truncated message of Quickbar

Post by Olivier Sessink
I think this line was added because this label was making the minimum
horizontal width of the bluefish window quite big.

Looking at my archive of commit messages, that actually goes back to
2004 :), you committed the change to fix a bug if the htmlbar was shown
in the side panel. 
-----------
fixes the very wide label in the quickbar if it doesn't have items and
is shown in the sidepanel
Regards,
    Jim H
--
To unsubscribe from this list: send the line "unsubscribe bluefish-dev" in
Bluefish web site: http://bluefish.openoffice.nl/

[Olivier Sessink]

works for me too!

Olivier

Post by Andrius
if (htmlbar_v.in_sidepanel) {
gtk_label_set_line_wrap(GTK_LABEL(label), TRUE);
}
instead of
gtk_label_set_ellipsize(GTK_LABEL(label), PANGO_ELLIPSIZE_END);
Can You confirm?
Andrius
------------------------------------------------------------------------
*Sent:*
*Subject:* Re: html toolbar truncated message of Quickbar

Post by Olivier Sessink
I think this line was added because this label was making the

minimum

Post by Olivier Sessink
horizontal width of the bluefish window quite big.

Looking at my archive of commit messages, that actually goes back to
2004 :), you committed the change to fix a bug if the htmlbar was shown
in the side panel.
-----------
fixes the very wide label in the quickbar if it doesn't have items and
is shown in the sidepanel
Regards,
Jim H
--
To unsubscribe from this list: send the line "unsubscribe
bluefish-dev" in
http://www.ems.ru/cgi-bin/listargate.cgi
Bluefish web site: http://bluefish.openoffice.nl/

[Jim Hayward]

Post by Andrius
if (htmlbar_v.in_sidepanel) {
gtk_label_set_line_wrap(GTK_LABEL(label), TRUE);
}

Agreed. I think this is a good change that would not require any string
changes at this time.

Regards,
Jim H

[Andrius]

Commited!

________________________________
Sent: Sunday, April 6, 2014 9:05 PM
Subject: Re: html toolbar truncated message of Quickbar

Post by Andrius
if (htmlbar_v.in_sidepanel) {
            gtk_label_set_line_wrap(GTK_LABEL(label), TRUE);
        }

Agreed. I think this is a good change that would not require any string
changes at this time.
Regards,
    Jim H
--
To unsubscribe from this list: send the line "unsubscribe bluefish-dev" in
Bluefish web site: http://bluefish.openoffice.nl/