SF.net SVN: bluefish:[8344] trunk/bluefish/src/bfwin.c

[Olivier Sessink]

I think there are quite some users that resize it to almost zero regularly. So even if that makes some parts of the UI a bit weird , I think we should keep that functionality . Anybody else a comment on that?

Olivier

Revision: 8344
http://sourceforge.net/p/bluefish/code/8344
Author: andriusrin
Date: 2014-05-01 07:29:39 +0000 (Thu, 01 May 2014)
-----------
When resizing filebrowser pane, when width of the pane gets narrower
than natural width of notebook tabs, there are variuos drawing
artefacts. This change does not allow to shrink filebrowser pane too
much and avoids weird looking UI.
--------------
trunk/bluefish/src/bfwin.c
Modified: trunk/bluefish/src/bfwin.c
===================================================================
--- trunk/bluefish/src/bfwin.c 2014-04-30 18:20:34 UTC (rev 8343)
+++ trunk/bluefish/src/bfwin.c 2014-05-01 07:29:39 UTC (rev 8344)
@@ -323,11 +323,11 @@
G_CALLBACK(side_panel_notify_position), bfwin);
bfwin->leftpanel_notebook = side_panel_build(bfwin);
if (main_v->props.left_panel_left) {
- gtk_paned_pack1(GTK_PANED(bfwin->hpane), bfwin->leftpanel_notebook,
FALSE, TRUE);
- gtk_paned_pack2(GTK_PANED(bfwin->hpane), bfwin->notebook_box, TRUE,
TRUE);
+ gtk_paned_pack1(GTK_PANED(bfwin->hpane), bfwin->leftpanel_notebook,
FALSE, FALSE);
+ gtk_paned_pack2(GTK_PANED(bfwin->hpane), bfwin->notebook_box, TRUE,
FALSE);
} else {
- gtk_paned_pack1(GTK_PANED(bfwin->hpane), bfwin->notebook_box, TRUE,
TRUE);
- gtk_paned_pack2(GTK_PANED(bfwin->hpane), bfwin->leftpanel_notebook,
FALSE, TRUE);
+ gtk_paned_pack1(GTK_PANED(bfwin->hpane), bfwin->notebook_box, TRUE,
FALSE);
+ gtk_paned_pack2(GTK_PANED(bfwin->hpane), bfwin->leftpanel_notebook,
FALSE, FALSE);
}
gtk_box_pack_start(GTK_BOX(bfwin->middlebox), bfwin->hpane, TRUE,
TRUE, 0);
gtk_widget_show(bfwin->hpane);
This was sent by the SourceForge.net collaborative development
platform, the world's largest Open Source development site.
To unsubscribe from this list: send the line "unsubscribe bluefish-cvs"
in
panel at http://www.ems.ru/cgi-bin/listargate.cgi
Bluefish web site: http://bluefish.openoffice.nl/

[Andrius Rinkevicius]

I think there is possibility to hide side panel completely from View menu.
Why do not use it instead of resizing?

Post by Olivier Sessink
I think there are quite some users that resize it to almost zero
regularly. So even if that makes some parts of the UI a bit weird , I think
we should keep that functionality . Anybody else a comment on that?
Olivier

Revision: 8344
http://sourceforge.net/p/bluefish/code/8344
Author: andriusrin
Date: 2014-05-01 07:29:39 +0000 (Thu, 01 May 2014)
-----------
When resizing filebrowser pane, when width of the pane gets narrower than natural width of notebook tabs, there are variuos drawing artefacts. This change does not allow to shrink filebrowser pane too much and avoids weird looking UI.
--------------
trunk/bluefish/src/bfwin.c
Modified: trunk/bluefish/src/bfwin.c
------------------------------
--- trunk/bluefish/src/bfwin.c 2014-04-30 18:20:34 UTC (rev 8343)
+++ trunk/bluefish/src/bfwin.c 2014-05-01 07:29:39 UTC (rev 8344)
@@ -323,11 +323,11 @@
G_CALLBACK(side_panel_notify_position), bfwin);
bfwin->leftpanel_notebook = side_panel_build(bfwin);
if (main_v->props.left_panel_
left)
{
- gtk_paned_pack1(GTK_PANED(bfwin->hpane), bfwin->leftpanel_notebook, FALSE, TRUE);
- gtk_paned_pack2(GTK_PANED(bfwin->hpane), bfwin->notebook_box, TRUE, TRUE);
+ gtk_paned_pack1(GTK_PANED(bfwin->hpane), bfwin->leftpanel_notebook, FALSE, FALSE);
+ gtk_paned_pack2(GTK_PANED(bfwin->hpane), bfwin->notebook_box, TRUE, FALSE);
} else {
- gtk_paned_pack1(GTK_PANED(bfwin->hpane), bfwin->notebook_box, TRUE, TRUE);
- gtk_paned_pack2(GTK_PANED(bfwin->hpane), bfwin->leftpanel_notebook, FALSE, TRUE);
+ gtk_paned_pack1(GTK_PANED(bfwin->hpane), bfwin->notebook_box, TRUE, FALSE);
+ gtk_paned_pack2(GTK_PANED(bfwin->hpane), bfwin->leftpanel_notebook, FALSE, FALSE);
}
gtk_box_pack_start(GTK_BOX(bfwin->middlebox), bfwin->hpane, TRUE, TRUE, 0);
gtk_widget_show(bfwin->hpane);
This was sent by the SourceForge.
net <http://SourceForge.net>
collaborative development platform, the world's largest Open Source development site.
To unsubscribe from this list: send the line "unsubscribe bluefish-cvs" in
panel at http://www.ems.ru/cgi-bin/listargate.cgi
Bluefish web site: http://bluefish.openoffice.nl/

[Olivier Sessink]

Post by Andrius Rinkevicius
I think there is possibility to hide side panel completely from View
menu. Why do not use it instead of resizing?

Completely true. However I remember for sure seeing quite a few bug
reports in the past regarding not being able to resize the sidepane to a
very small size. So obviously there are several users that expect this
behaviour.

regards,
Olivier

[Andrius Rinkevicius]

Sorry, I did not knew the history. On MacOSX window manager probably does
not work perfectly, and I have situation when resizing side panel to zero
hide also resizing handle, so there is no way to get panel back, You have
to hide and unhide it from View menu. So, I would suggest do not allow to
shrink it to zero at least on MacOSX.
Andrius

Post by Olivier Sessink
Completely true. However I remember for sure seeing quite a few bug
reports in the past regarding not being able to resize the sidepane to a
very small size. So obviously there are several users that expect this
behaviour.

[Olivier Sessink]

No problem. The issue you describe is not visible on Linux (at least not
on my current Ubuntu desktop). Can we easily force the minimum size > 5
px or so for this osx issue?

Olivier

Post by Andrius Rinkevicius
Sorry, I did not knew the history. On MacOSX window manager probably
does not work perfectly, and I have situation when resizing side panel
to zero hide also resizing handle, so there is no way to get panel
back, You have to hide and unhide it from View menu. So, I would
suggest do not allow to shrink it to zero at least on MacOSX.
Andrius
Completely true. However I remember for sure seeing quite a few bug
reports in the past regarding not being able to resize the
sidepane to a
very small size. So obviously there are several users that expect this
behaviour.

[Andrius Rinkevicius]

Unfortunately, on MacOSX I am not able to force 5px size. I tried to add
gtk_widget_set_size_request (bfwin->leftpanel_notebook, 5, -1);
but it seems not having effect for any resize/shrink flags combinations.
On MacOSX the weird thing is that when resize/shrink flags are set to
TRUE/TRUE, instead of shrinking or cropping visible area the left notebook
is "pushed" out of screen as one can see in attached picture. Probably this
is some bug in 3.6.4 or in Quartz backend, but I feel there is too much
effort to track it down.
So, I would suggest to add define for MacOSX to the code... Is this OK?
Andrius


No problem. The issue you describe is not visible on Linux (at least not on
my current Ubuntu desktop). Can we easily force the minimum size > 5 px or
so for this osx issue?

[Olivier Sessink]

Post by Andrius Rinkevicius
Unfortunately, on MacOSX I am not able to force 5px size. I tried to add
gtk_widget_set_size_request (bfwin->leftpanel_notebook, 5, -1);
but it seems not having effect for any resize/shrink flags combinations.
On MacOSX the weird thing is that when resize/shrink flags are set to
TRUE/TRUE, instead of shrinking or cropping visible area the left
notebook is "pushed" out of screen as one can see in attached picture.
Probably this is some bug in 3.6.4 or in Quartz backend, but I feel
there is too much effort to track it down.
So, I would suggest to add define for MacOSX to the code... Is this OK?

yes, seems like a valid reason. You might want to add a comment
explaining the bug, so we can later track down why we created the #ifdef.

Olivier