Restore mouse wheel tab scrolling for gtk+3 build

[Andrius]

Hi everyone,
Notebook tab scrolling using mouse wheel was removed in gtk+3 for some unknown reasons. (see https://bugzilla.gnome.org/show_bug.cgi?id=630226 for details for this decision).
I made patch that would restore old gtk+2 behavior for all gtk+3 builds. Would it make sense to get it back?
I also noticed one issue when using this patch. When I do fast scrolling sometimes syntax scanner stops working and F5 does not activates it again. More likely this happens when there are many documents opened and they do not fit into notebook bar, so scroll arrows appears on the sides of notebook bar. It will be necessary to look what might cause this behavior.
Andrius

[Andrius]

Found a way to avoid problems with syntax scanner- there was small glitch in bftextview2.c. Attaching improved patch.

________________________________
Sent: Saturday, November 16, 2013 10:45 AM
Subject: Restore mouse wheel tab scrolling for gtk+3 build
Hi everyone,
Notebook tab scrolling using mouse wheel was removed in gtk+3 for some unknown reasons. (see https://bugzilla.gnome.org/show_bug.cgi?id=630226 for details for this decision).
I made patch that would restore old gtk+2 behavior for all gtk+3 builds. Would it make sense to get it back?
I also noticed one issue when using this patch. When I do fast scrolling sometimes syntax scanner stops working and F5 does not activates it again. More likely this happens when there are many documents opened and they do not fit into notebook bar, so scroll arrows appears on the sides of notebook bar. It will be necessary to look what might cause this behavior.
Andrius

[Andrius]

Well, third version of patch is required :-) since sanity check is required after all, when textview does not have scroll bars and scroll events are not consumed.

________________________________
Sent: Sunday, November 17, 2013 2:02 PM
Subject: Re: Restore mouse wheel tab scrolling for gtk+3 build
Found a way to avoid problems with syntax scanner- there was small glitch in bftextview2.c. Attaching improved patch.

________________________________
Sent: Saturday, November 16, 2013 10:45 AM
Subject: Restore mouse wheel tab scrolling for gtk+3 build
Hi everyone,
Notebook tab scrolling using mouse wheel was removed in gtk+3 for some unknown reasons. (see https://bugzilla.gnome.org/show_bug.cgi?id=630226 for details for this decision).
I made patch that would restore old gtk+2 behavior for all gtk+3 builds. Would it make sense to get it back?
I also noticed one issue when using this patch. When I do fast scrolling sometimes syntax scanner stops working and F5 does not activates it again. More likely this happens when there are many documents opened and they do not fit into notebook bar, so scroll arrows appears on the sides of notebook bar. It will be necessary to look what might cause this behavior.
Andrius

[Olivier Sessink]

Post by Andrius
Found a way to avoid problems with syntax scanner- there was small
glitch in bftextview2.c. Attaching improved patch.

well spotted. There was even one more bug: btv->scanner_idle should also
be set to 0 before returning FALSE. Fixed those in svn.

Olivier

[Olivier Sessink]

Post by Andrius
Hi everyone,
Notebook tab scrolling using mouse wheel was removed in gtk+3 for some
unknown reasons. (see https://bugzilla.gnome.org/show_bug.cgi?id=630226
for details for this decision).
I made patch that would restore old gtk+2 behavior for all gtk+3 builds.
Would it make sense to get it back?

I've never used it myself (I usually right-click the notebook when I
need to switch to a specific document), how do other people feel about
this feature? Should we implement this within Bluefish? Make it optional?

Olivier

[Andrius]

This feature is present in Windows builds, probably starting from 2.2.2. I liked it... Very useful when need to access tab that is out of window, or when You want quickly check what is inside of opened files.

________________________________
I've never used it myself (I usually right-click the notebook when I
need to switch to a specific document), how do other people feel about
this feature? Should we implement this within Bluefish? Make it optional?

[Andrius]

Since nobody objected, but at the same time nobody okayed, should I commit it as MacOSX-only feature?
Andrius

________________________________
how do other people feel about
this feature? Should we implement this within Bluefish? Make it optional?

[Olivier Sessink]

Post by Andrius
Since nobody objected, but at the same time nobody okayed, should I
commit it as MacOSX-only feature?
Andrius

________________________________
how do other people feel about
this feature? Should we implement this within Bluefish? Make it

optional?

Why mac only? Just commit for all?!!

Olivier